Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#9577): support deep object as dynamic arguments #9585

Merged
merged 4 commits into from Feb 28, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiler/parser/index.js
Expand Up @@ -33,7 +33,7 @@ const dynamicArgRE = /^\[.*\]$/
const argRE = /:(.*)$/
export const bindRE = /^:|^\.|^v-bind:/
const propBindRE = /^\./
const modifierRE = /\.[^.]+/g
const modifierRE = /\.[^.\]]+(?=[^\]]*$)/g

const slotRE = /^v-slot(:|$)|^#/

Expand Down
78 changes: 78 additions & 0 deletions test/unit/features/options/directives.spec.js
Expand Up @@ -287,4 +287,82 @@ describe('Options directives', () => {
}).$mount()
vm.key = 'bar'
})

it('deep object like `deep.a` as dynamic arguments', done => {
const vm = new Vue({
template: `<div v-my:[deep.a]="1"/>`,
data: {
deep: {
a: 'foo'
}
},
directives: {
my: {
bind(el, binding) {
expect(binding.arg).toBe('foo')
},
update(el, binding) {
expect(binding.arg).toBe('bar')
expect(binding.oldArg).toBe('foo')
done()
}
}
}
}).$mount()
vm.deep.a = 'bar'
})

it('deep object like `deep.a.b` as dynamic arguments', done => {
const vm = new Vue({
template: `<div v-my:[deep.a.b]="1"/>`,
data: {
deep: {
a: {
b: 'foo'
}
}
},
directives: {
my: {
bind(el, binding) {
expect(binding.arg).toBe('foo')
},
update(el, binding) {
expect(binding.arg).toBe('bar')
expect(binding.oldArg).toBe('foo')
done()
}
}
}
}).$mount()
vm.deep.a.b = 'bar'
shasharoman marked this conversation as resolved.
Show resolved Hide resolved
})

it('deep object as dynamic arguments with modifiers', done => {
const vm = new Vue({
template: `<div v-my:[deep.a.b].x.y="1"/>`,
data: {
deep: {
a: {
b: 'foo'
}
}
},
directives: {
my: {
bind(el, binding) {
expect(binding.arg).toBe('foo')
expect(binding.modifiers.x).toBe(true)
expect(binding.modifiers.y).toBe(true)
},
update(el, binding) {
expect(binding.arg).toBe('bar')
expect(binding.oldArg).toBe('foo')
done()
}
}
}
}).$mount()
vm.deep.a.b = 'bar'
})
shasharoman marked this conversation as resolved.
Show resolved Hide resolved
})