Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #9224 Warn when the type of a prop isn't a constructor #9227

Closed
wants to merge 1 commit into from
Closed

fix #9224 Warn when the type of a prop isn't a constructor #9227

wants to merge 1 commit into from

Conversation

cedric05
Copy link

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@cedric05 cedric05 changed the title fix[#9224] Warn when the type of a prop isn't a constructor fix #9224 Warn when the type of a prop isn't a constructor Dec 19, 2018
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks but this is missing many things: it should be a development only warning and it should contain tests 🙂

@cedric05
Copy link
Author

@posva thanks for pointing out.
what would be correct place to write tests for above usecase. if not i will be writing in unit folder.
am i missing any thing else other than writing tests?

@posva
Copy link
Member

posva commented Dec 20, 2018

look for other tests about warnings. Specifically the ones for props should help

@posva
Copy link
Member

posva commented Jan 14, 2019

Closing in favor of #9241

@posva posva closed this Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants