fix(ssr): vue-ssr-webpack-plugin compatible with webpack 4/5 #11863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 really need this |
|
Can this be merged? |
blake-newman
suggested changes
Jan 30, 2021
| } | ||
| // Webpack >= 5.0.0 | ||
| else if (compiler.options.output.library && compiler.options.output.library.type !== 'commonjs2') { | ||
| warn('webpack config `output.libraryTarget` should be "commonjs2".') |
There was a problem hiding this comment.
@blake-newman According to the webpack 5 documentation, I dont think output.library.type is what's required in the webpack config.
The config supports output.libraryTarget: 'commonjs2' as until now.
Indeed, the logic here should read the value from library.type (I haven't checked, trusting the author on this one), but the warning to users needs to mention the proper webpack config - which is still output.libraryTarget.
|
Waiting for update |
|
what about making these changes on vue-server-renderer/server-plugin.js? |
lmiller1990
reviewed
Mar 25, 2021
lmiller1990
reviewed
Mar 25, 2021
lmiller1990
reviewed
Mar 25, 2021
posva
changed the title
posva
reviewed
Mar 30, 2021
Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>
13 tasks
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #11718
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: