Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(factory): improve fallback multiple v-if #11857

Closed
wants to merge 2 commits into from

Conversation

KSH-code
Copy link

@KSH-code KSH-code commented Jan 7, 2021

close #11856

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@KSH-code
Copy link
Author

KSH-code commented Jan 7, 2021

This is the very first time I create Pull Request to vuejs, If description is bad, please let me know. then I'll edit.

@sirlancelot
Copy link

You will probably want to make this change to the source file instead of just the weex output: src/core/vdom/helpers/normalize-scoped-slots.js

@KSH-code
Copy link
Author

KSH-code commented Jan 8, 2021

Nice to point out mistake!
files of packages directory are made by build, right?

@KSH-code KSH-code closed this Feb 15, 2021
@KSH-code KSH-code reopened this May 27, 2021
@KSH-code KSH-code closed this May 27, 2021
@KSH-code KSH-code reopened this Nov 24, 2021
@posva posva added this to Planned in 2.6.15 via automation Nov 24, 2021
@KSH-code KSH-code closed this Apr 18, 2022
2.6.15 automation moved this from Planned to Done Apr 18, 2022
@posva posva reopened this Apr 18, 2022
2.6.15 automation moved this from Done to Planned Apr 18, 2022
@KSH-code
Copy link
Author

KSH-code commented May 2, 2022

@posva
When it will be merged? it was reviewed over 1 year ago.

@KSH-code
Copy link
Author

@posva @yyx990803
When it will be merged? 🤔
I've seen release 2.7 was released.

@KSH-code
Copy link
Author

@posva @yyx990803

@KSH-code KSH-code closed this Sep 14, 2022
2.6.15 automation moved this from Planned to Done Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

empty slot does not render as default if there is v-if as evaluated false more than 1
3 participants