Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): avoid converting &nbps; to spaces #11065

Merged
merged 2 commits into from Mar 30, 2021
Merged

fix(compiler): avoid converting &nbps; to spaces #11065

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e15a402
fix(compiler): avoid converting &nbps; to spaces (fix #11059)
despreston Feb 2, 2020
7fb1f98
perf(compiler): include form-feed char as part of whitespace regex
despreston Feb 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiler/parser/index.js
View file
Open in desktop
Expand Up @@ -38,7 +38,7 @@ const modifierRE = /\.[^.\]]+(?=[^\]]*$)/g
const slotRE = /^v-slot(:|$)|^#/

const lineBreakRE = /[\r\n]/
const whitespaceRE = /\s+/g
const whitespaceRE = /[ \t\r\n]+/g
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use space characters defined in HTML spec here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thats a good idea. The only possible char missing from the regex at this point would be U+000C FORM FEED (FF)


const invalidAttributeRE = /[\s"'<>\/=]/

Expand Down
8 changes: 8 additions & 0 deletions test/unit/modules/compiler/parser.spec.js
View file
Open in desktop
Expand Up @@ -845,6 +845,14 @@ describe('parser', () => {
expect(ast.children[4].children[0].text).toBe('. Have fun! ')
})

it(`maintains &nbsp; with whitespace: 'condense'`, () => {
const options = extend({}, condenseOptions)
const ast = parse('<span>&nbsp;</span>', options)
const code = ast.children[0]
expect(code.type).toBe(3)
expect(code.text).toBe('\xA0')
})

it(`preserve whitespace in <pre> tag with whitespace: 'condense'`, function () {
const options = extend({}, condenseOptions)
const ast = parse('<pre><code> \n<span>hi</span>\n </code><span> </span></pre>', options)
Expand Down