Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serialize-javascript vulnerability by updating package (#10910) #10911

Closed
wants to merge 4 commits into from
Closed

Conversation

staghouse
Copy link

@staghouse staghouse commented Dec 9, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: Security Vulnerability

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove all generated files related changes and only include package.json files changes, please?

@posva
Copy link
Member

posva commented Dec 9, 2019

Note: there is a breaking change regarding how objects with an undefined value are serialized: yahoo/serialize-javascript#57
Must include

Close #10910

when squashing

@posva
Copy link
Member

posva commented Dec 9, 2019

Closing in favor of #10904 It's missing the upgrade in the package.json file

@posva posva closed this Dec 9, 2019
@posva posva reopened this Dec 9, 2019
@staghouse
Copy link
Author

Please check again. My history got a bit hairy with the revert. If this PR is still broken I will close and open a clean PR without running the tests.

@posva posva self-requested a review December 9, 2019 13:28
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only package.json files must end up modified. Feel free to submit a new PR if that's easier for you

@staghouse
Copy link
Author

Problem is I'll have to --no-verify passed the linter as it seems to correct some issues on commit, is this acceptable?

@posva
Copy link
Member

posva commented Dec 9, 2019

it shouldn't be a problem but yes, you can do that and the PR might still be valid

@staghouse
Copy link
Author

Closing in favor of #10914

@staghouse staghouse closed this Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants