Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Vue.config.errorHandler should capture rejected promised in watc… #10013

Closed
wants to merge 1 commit into from

Conversation

underfin
Copy link
Member

…hers(#10009)

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@underfin
Copy link
Member Author

The error is not related.

@hello-brsd
Copy link
Contributor

This pr does not handling the promise rejection in watchers with immediate option, but #9484 does.

@underfin
Copy link
Member Author

@hello-brsd ,you are right. I will close this pr.

@underfin underfin closed this May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants