Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump serialize-javascript from 1.3.0 to 2.1.2 #10914

Merged
merged 3 commits into from Dec 13, 2019
Merged

build(deps-dev): bump serialize-javascript from 1.3.0 to 2.1.2 #10914

merged 3 commits into from Dec 13, 2019

Conversation

mateusvelleda
Copy link
Contributor

@mateusvelleda mateusvelleda commented Dec 9, 2019

What kind of change does this PR introduce?

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

Other information:
Since I couldn't find the reason for pinning webpack at shakir-abdo@bb0aab6 I just upgrade it. I've done it due to webpack#terser-webpack-plugin#serialize-javascript that would keep the vulnerable version in the deps

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the webpack upgrade and the yarn.lock modification, please?

@mateusvelleda
Copy link
Contributor Author

mateusvelleda commented Dec 9, 2019

can you remove the webpack upgrade and the yarn.lock modification, please?

@posva it's done. Sincerely I tried to found a reason for the pinned version of webpack. I know it's a XSS vulnerability, so build tools are not affected. I was just thinking that GitHub vulnerability alerts will keep warning due to having the vulnerable version in yarn.lock due to webpack#terser-webpack-plugin#serialize-javascript

@mateusvelleda mateusvelleda changed the title build(deps-dev): bump serialize-javascript and webpack build(deps-dev): bump serialize-javascript from 1.3.0 to 2.1.2 Dec 9, 2019
@posva posva added dependencies Pull requests that update a dependency file priority: high ready to merge semver:minor labels Dec 9, 2019
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva
Copy link
Member

posva commented Dec 9, 2019

It's fine for webpack. It will be updated at a different time

@mateusvelleda
Copy link
Contributor Author

@posva any idea about when it's gonna be released?

@vue-bot
Copy link
Contributor

vue-bot commented Dec 13, 2019

Hey @mateusvelleda, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file priority: high ready to merge semver:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants