Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactoring tests and simplifying setProps #1414

Merged
merged 1 commit into from Jan 24, 2020

Conversation

JessicaSachs
Copy link
Collaborator

@JessicaSachs JessicaSachs commented Jan 22, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
This PR comes after investigating #1300 and in preparation of fixing #1140.

@JessicaSachs JessicaSachs force-pushed the chore/refactor-set-props-after-sync-mode-deletion branch from 29d179d to 37744cd Compare January 22, 2020 14:29
Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff is big, but I don't see anything super suspect. Happy to merge this up, we def need to tackle some of the complexity.

@lmiller1990 lmiller1990 merged commit c979087 into dev Jan 24, 2020
@lmiller1990 lmiller1990 deleted the chore/refactor-set-props-after-sync-mode-deletion branch January 24, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants