Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scroll): allow behavior in scrollBehavior #3210

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

feat(scroll): allow behavior in scrollBehavior #3210

wants to merge 1 commit into from

Conversation

posva
Copy link
Member

@posva posva commented May 27, 2020 •
edited

Closes #2069
Closes #3008

pikax
pikax approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@pikax pikax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/util/scroll.js
const left = isNumber(obj.left) ? obj.left : obj.x
const top = isNumber(obj.top) ? obj.top : obj.y
// defaultLeft = isNumber(defaultLeft) ? defaultLeft : window.pageXOffset
// defaultTop = isNumber(defaultTop) ? defaultTop : window.pageYOffset
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to add it back 👀

@posva posva marked this pull request as draft May 28, 2020 12:42
@posva
Copy link
Member Author

posva commented May 28, 2020

I've had a better idea for this API: #3008 (comment)

@posva posva added the fixed on 4.x This issue has been already fixed on the v4 but exists in v3 label Aug 3, 2020
@posva posva added this to In Progress in v3 pre v4 Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pikax pikax pikax approved these changes

Assignees
No one assigned
Labels
fixed on 4.x This issue has been already fixed on the v4 but exists in v3
Projects
v3 pre v4
In Progress
Milestone
No milestone
2 participants
@posva @pikax