Adding children and parent to currentRoute #1941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
reviewed
Jan 7, 2018
src/util/route.js
Outdated
| @@ -21,6 +21,8 @@ export function createRoute ( | |||
| const route: Route = { | |||
| name: location.name || (record && record.name), | |||
| meta: (record && record.meta) || {}, | |||
| children: (record && record.children) || [], | |||
| parent: (record && record.parent) || {}, | |||
There was a problem hiding this comment.
Isn't it better to have null or undefined if the parent does not exist?
There was a problem hiding this comment.
Yes, I think it would be. I'll update it.
|
Sorry for taking so much time in getting this a read! |
|
Opening #1991 to replace this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adding .vscode (IDE settings file) to .gitignore
@posva I'd like to have the feature #1650 was trying to add but it looks like there are too many unrelated changes in that PR and it hasn't been updated with your comments for a little while so I decided to try re-work it here. Thank you for your consideration.