Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: add loader options declarations #1541

Closed
wants to merge 1 commit into from
Closed

types: add loader options declarations #1541

wants to merge 1 commit into from

Conversation

kbtz
Copy link

@kbtz kbtz commented Apr 23, 2019

Please note the compiler interface use types that were added only in Vue 2.6 (vuejs/vue#7918), but folks with older versions of the template compiler shouldn't experience any errors, they will just not get type checking on compile and compileOptions properties.

@yyx990803 yyx990803 requested a review from sodatea April 23, 2019 07:34
Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are loader options, not plugin options.

@kbtz kbtz changed the title types: add plugin options declarations types: add loader options declarations Apr 23, 2019
@kbtz
Copy link
Author

kbtz commented Apr 23, 2019

@sodatea My bad, thanks!
There's any problem in force-pushing my own fork? I can recreate the PR if that's the case.

@yyx990803
Copy link
Member

@kbtzr you can just push. GitHub can auto-squash before merging.

@kbtz
Copy link
Author

kbtz commented Apr 23, 2019

@sodatea it seems that your request for changes got stuck on ea26afa that got overwritten by my force push. I'm closing this PR in favor of #1542, sorry for the confusion its one of my first PRs.

@kbtz kbtz closed this Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants