Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for stylelint #1343

Merged
merged 3 commits into from Jul 3, 2018
Merged

Add doc for stylelint #1343

merged 3 commits into from Jul 3, 2018

Conversation

gucong3000
Copy link

@gucong3000 gucong3000 commented Jun 12, 2018

Related: #303

  • en
  • zh
  • ru

@gucong3000
Copy link
Author

@yyx990803
If you like this PR, I will find someone to help translate it to Russian.

@gucong3000
Copy link
Author

Anyone make any comments?

@kazupon
Copy link
Member

kazupon commented Jul 3, 2018

/ping @Alex-Sokolov
Can you help translation about it?

@gucong3000
Copy link
Author

Does anyone have any comments on the Chinese and English parts?

@kazupon
Copy link
Member

kazupon commented Jul 3, 2018

On second thought 🤔, I think that we don't have to put it to Vue Loader documentation, because stylelint is not necessarily required linter and it optional set with user.

@Alex-Sokolov
Copy link

@kazupon done (gucong3000#1), needed merge from @gucong3000

P.S.: Can you merge #1342

@gucong3000
Copy link
Author

gucong3000 commented Jul 3, 2018

stylelint is not necessarily required linter

I don't quite understand why the linter of CSS code is less important than JS?
CSS code is as important to a project as JS, so they also need linter

@gucong3000 gucong3000 changed the title [WIP] Add doc for stylelint Add doc for stylelint Jul 3, 2018
@gucong3000
Copy link
Author

Stylelint is used by Facebook, Wikipedia and GitHub.

create-react-app will support it.

Right now it is the most popular CSS linter.

@kazupon
Copy link
Member

kazupon commented Jul 3, 2018

@gucong3000
Yeah, Linter of CSS codes is very important.
However, I think should not include how to setting of Stylelint, due to already exist as Stylelint documentation.
https://github.com/webpack-contrib/stylelint-webpack-plugin

@gucong3000
Copy link
Author

due to already exist as Stylelint documentation.
https://github.com/webpack-contrib/stylelint-webpack-plugin

It does not contain *.vue file configuration.

@yyx990803
Copy link
Member

yyx990803 commented Jul 3, 2018

I think this is good to have. Thanks!

@kazupon I think it's nice to provide related information as people may not realize stylelint already works with Vue files.

@yyx990803 yyx990803 merged commit 791999a into vuejs:master Jul 3, 2018
@kazupon
Copy link
Member

kazupon commented Jul 3, 2018

@yyx990803
okay! I got it!

@gucong3000 gucong3000 deleted the stylelint branch July 4, 2018 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants