Fix: script and script setup in same vue component file (Vue 3) #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Does this fail locally before the change, and pass after? I'll go ahead and run CI now, it should run automatically each commit now. |
quienti
force-pushed
the
fix-script-and-script-setup-vue3
branch
from
015a33d
to
2a07fd6
Compare
|
@lmiller1990 , I have add missing import for test, I think it is okay now ! |
quienti
force-pushed
the
fix-script-and-script-setup-vue3
branch
from
2a07fd6
to
347f85c
Compare
|
Ok, I thought the mount method was from the test-utils package.... All is good now :D |
|
Seems fine, I will release this now. |
|
Thank you ! Everything work ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.