Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue2-jest): interop custom transformer require #390

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(vue2-jest): interop custom transformer require #390

wants to merge 1 commit into from

Conversation

blake-newman
Copy link
Member

@blake-newman blake-newman commented Sep 30, 2021 •
edited

interop custom transformer require. Some transformers may not interop correctly when requiring, return transformer.default or transformer.

@vue/vue3-jest fix: #391
fixes #383

@blake-newman
fix(vue2-jest): interop custom transformer require
2afdad4 
interop custom transformer require. Some transformers may not
interop correctly when requiring, return `transformer.default` or `transformer`.

fixes vuejs#383
@blake-newman blake-newman mentioned this pull request Sep 30, 2021
Merged
cexbrayat
cexbrayat reviewed Oct 1, 2021
View reviewed changes
Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing as in #391 : a test would be great!

@nogic1008 nogic1008 added upstream Due to other packages (like Jest) vue2-jest Vue 2 labels Oct 17, 2021
@lmiller1990
Copy link
Member

Any chance of a test for this? Or maybe someone else can pick it up?

@blake-newman
Copy link
Member Author

@lmiller1990 sorry not had a chance to pick up yet. I'll be picking up shortly

@nogic1008 nogic1008 reopened this Nov 28, 2021
@lmiller1990
Copy link
Member

lmiller1990 commented Sep 22, 2022 •
edited

I wonder if we still need this? Is this still an issue on Jest 29 + Vue 2 + vue/vue2-jest@29?

@blake-newman
Copy link
Member Author

@lmiller1990 i'll mark the PR as draft. It may not be needed but yet to upgrade jest to that version.

@blake-newman blake-newman marked this pull request as draft October 19, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cexbrayat cexbrayat cexbrayat left review comments

@leonardobenedet leonardobenedet leonardobenedet approved these changes

@nogic1008 nogic1008 nogic1008 approved these changes

@JessicaSachs JessicaSachs Awaiting requested review from JessicaSachs

@lmiller1990 lmiller1990 Awaiting requested review from lmiller1990

Assignees
No one assigned
Labels
upstream Due to other packages (like Jest) vue2-jest Vue 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v.27.0.0-alpha.2 - TypeError: Jest: a transform must export a process function.
5 participants
@blake-newman @lmiller1990 @cexbrayat @leonardobenedet @nogic1008