Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: setup GitHub Actions #278

Merged
merged 11 commits into from Mar 25, 2021
Merged

ci: setup GitHub Actions #278

merged 11 commits into from Mar 25, 2021

Conversation

nogic1008
Copy link
Collaborator

@nogic1008 nogic1008 commented Sep 11, 2020 •
edited

Note: To take advantage of this PR, you need to enable GitHub Actions on this repository.
sample jobs

  • Setup GitHub Actions workflow
    • Node.js 10, 12, 14
    • Jest 24, 25, 26
  • bump @babel/core and @babel/preset-env to 7.9.0 to fix error in Node.js 12 or above

@lmiller1990
Copy link
Member

Interesting. Is there an advantage to GH actions over Circle CI for example?

@nogic1008
Copy link
Collaborator Author

@lmiller1990

Advantage:

  • Circle CI cannot watch test results without signing up, but GitHub Actions can do.
  • Circle CI can also use matrix jobs, but free plan don't run in parallel. It will take more time.
  • Testing can be done even in forked repositories. (need to opt in there)
  • Lots of reusable actions (like orb in Circle CI) are available in the community.

Disadvantage:

  • GitHub Actions cannot rerun job partially. only can "Rerun All".
  • It is difficult to access the running job with SSH etc.

@lmiller1990
Copy link
Member

Sounds like we should ues GH actions. I will look into this on the weekend. Thanks!

@nogic1008
Copy link
Collaborator Author

@lmiller1990
Thank you for your interest.
This PR conflicts with #284, so I'll rebase it after 284 has been merged.

@nogic1008
Copy link
Collaborator Author

@lmiller1990
Ready to merge. After merged, we can delete /.circleci folder safely.
GitHub Actions result

@lmiller1990
Copy link
Member

Forgot this, sorry! I sent you a msg on Twitter regarding this PR, let's chat.

@nogic1008 nogic1008 merged commit 28abe4d into vuejs:master Mar 25, 2021
@nogic1008 nogic1008 deleted the ci/github-actions branch March 25, 2021 04:11
@lmiller1990
Copy link
Member

Thanks @nogic1008, feel free to make any other improvements you see, I can review your PRs :)

@nogic1008 nogic1008 mentioned this pull request Mar 29, 2021
Merged
nogic1008 added a commit that referenced this pull request Mar 29, 2021
@nogic1008
ci: setup GitHub Actions to next branch (#326)
acab463 
* ci: enable GitHub Actions (Port from #278)
* chore: update test run script (Port from #284)
* chore: remove yarn lock file
* chore(deps): bump e2e projects deps version
* chore: hoist package dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nogic1008 @lmiller1990