Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use tsconfig.readFileSync #120

Closed
wants to merge 1 commit into from
Closed

use tsconfig.readFileSync #120

wants to merge 1 commit into from

Conversation

dojineko
Copy link

howdy! πŸ˜„

now tsConfigFile option is deprecated, and we should use tsConfig instead of it.
but i got a JSON.parse error when i switched it.

  ● Test suite failed to run

    SyntaxError: Unexpected token m in JSON at position 0
        at JSON.parse (<anonymous>)

      at Object.parseSourceMapInput (node_modules/source-map/lib/util.js:433:15)
      at new SourceMapConsumer (node_modules/source-map/lib/source-map-consumer.js:17:22)
          at Array.map (<anonymous>)
          at Generator.throw (<anonymous>)

i made tsConfigFile and tsConfig the same behavior when string supplied to tsConfig.

Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, can you add a test that is fixed by your change?

@lmiller1990
Copy link
Member

It looks like this API has changed again - and someone is going to fix this in #246. Going to close this one off, as part of cleaning up this repo.

@lmiller1990 lmiller1990 closed this Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants