Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check hoisted postcss version #6372

Merged
merged 2 commits into from Mar 24, 2021
Merged

Conversation

sodatea
Copy link
Member

@sodatea sodatea commented Mar 24, 2021

Reverts #6358

@sodatea sodatea changed the title Revert "fix: work around npm6/postcss8 hoisting issue" fix: check hoisted postcss version Mar 24, 2021
@sodatea sodatea merged commit fa46ed4 into dev Mar 24, 2021
@sodatea sodatea deleted the revert-6358-fix-postcss-peer-dep branch March 24, 2021 12:28
`please run ${chalk.cyan('npm i postcss@8 -D')} to fix it.`
)
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if hasPostCSSConfig is true?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That means the user is not likely using the built-in autoprefixer plugin.
In that case, they should take care of the peer dependency requirements of their own installed plugins.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Projects created by Vue CLI < 4.1.0 may have a PostCSS configuration (which only adds autoprefixer) but no direct dependency installed. That's a bad practice. We can implement a migrator to help remove these configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants