refactor!: move vue-jest and ts-jest to peer dependencies #6347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vue-jest now requires several different peer deps for vue 2 and vue 3; ts-jest now requires typescript as peer dep, which should be optional for unit-jest plugin users because they might choose not to use typescript. Both are causing annoying peer dep warnings. So it only makes sense to move them to the project level, to keep things clean.
sodatea
changed the title
PiDelport
reviewed
May 3, 2021
Comment on lines
+12
to
+22
| if (!allDeps['vue-jest']) { | ||
| // Likely a Vue 2 project, and uses the builtin preset. | ||
| // Because we used to add `vue-jest` v5 to dev deps for Vue 3 projects. | ||
| toMerge['vue-jest'] = '^4.0.1' | ||
| } | ||
|
|
||
| if (allDeps['@vue/cli-plugin-typescript'] && !allDeps['ts-jest']) { | ||
| toMerge['ts-jest'] = '^26.5.3' | ||
| } | ||
|
|
||
| return toMerge |
There was a problem hiding this comment.
Likely bug: These lines end up adding values to the root of package.json itself, instead of under the dependencies / devDependencies keys?
There was a problem hiding this comment.
Oops, thanks for noticing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vue-jest now requires several different peer deps for vue 2 and vue 3;
ts-jest now requires typescript as peer dep, which should be optional
for unit-jest plugin users because they might choose not to use
typescript.
Both are causing annoying peer dep warnings.
So it only makes sense to move them to the project level, to keep things
clean.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: