Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about loader incompatible with webpack 4 #6265

Closed
wants to merge 144 commits into from

Conversation

JarnoRFB
Copy link
Contributor

@JarnoRFB JarnoRFB commented Feb 6, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:
sass-loader is incompatible with webpack 4 since https://github.com/webpack-contrib/sass-loader/releases/tag/v11.0.0. It might be good to include a note for users stumbling upon this problem.

sodatea and others added 30 commits September 7, 2020 20:52
Aside from the Node.js version requirement, these dependency version
bumps are not likely to bring in any user-facing breaking changes
…ities

chore(plugin): add link to cypress cross-browser guide

chore(dep): upgrade to cypress v4.0.0

chore(dep): upgrade to Cypress 4.0.1

chore(dep): upgrade to cypress v5.0.0
sodatea and others added 26 commits January 6, 2021 15:31
It causes peer dependency warnings because of several ill-maintained
apollo packages, but let's just ignore them.
Fixes vuejs#6191
When username and password are configured in the .npmrc for the
respective scope, use basic auth when getting package metadata from the
npm registry.

Closes vuejs#6206
…v4 (vuejs#6215)

Note this plugin is compatible with cli-service v4, therefore users can
upgrade to it separately for mocha major version upgrades
1. createRequire should have been properly handled in newer Jest
versions: jestjs/jest#9469
2. We don't test migrators with Jest mock modules anymore

So it's safe to skip that condition
See the reasoning at facebook/create-react-app#7633

This change should improve the build speed for large projects
)

Avoid empty `node_modules` when the user has set `NODE_ENV` to
`production` in the shell environment.

In the long run we should have a more comprehensive preflight check
for execution environment though.
Co-authored-by: Haoqun Jiang <haoqunjiang@gmail.com>
It's not used in any server-side code
vuejs#6230)

When the user sets the project public path to the absolute path, the extract-css publicPath option should be changed accordingly
sass-loader is incompatible with webpack 4 since https://github.com/webpack-contrib/sass-loader/releases/tag/v11.0.0. It might be good to include a note for users stumbling upon this problem.
@JarnoRFB
Copy link
Contributor Author

JarnoRFB commented Feb 6, 2021

Hi, I am new to vue and just hit this issue, so I thought it might be good to leave a note here. I also happy if this should be addressed in a different way.

@JarnoRFB JarnoRFB changed the base branch from dev to master February 6, 2021 17:56
@JarnoRFB
Copy link
Contributor Author

JarnoRFB commented Feb 6, 2021

ok sorry should have forked from master I guess. Openend #6266 instead.

@JarnoRFB JarnoRFB closed this Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet