Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent snoretoast shortcut, set notif title (#2720) #6000

Merged
merged 1 commit into from Nov 14, 2020

Conversation

tony19
Copy link
Contributor

@tony19 tony19 commented Oct 24, 2020

This prevents SnoreToast from installing a Start Menu shortcut by specifying an appID. The appID is also used to set the
notification's title bar text in Windows 10. That text is now set to "Vue UI", which replaces the default value of "SnoreToast".

fixes #2720

Screenshot of desktop notification on Windows 10:
desktop-notif

Screenshot of notification bar on Windows 10:
notif-bar

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

This prevents SnoreToast from installing a Start Menu shortcut
by specifying an appID. The appID is also used to set the
notification's title bar text in Windows 10. That text is now
set to "Vue UI", which replaces the default value of "SnoreToast".

fixes vuejs#2720
// SnoreToast actually uses it as the string in the notification's
// title bar (different from title heading inside notification).
// This only has an effect in Windows.
const snoreToastOptions = notifier.Notification === notifier.WindowsToaster && { appID: 'Vue UI' }
Copy link
Contributor Author

@tony19 tony19 Oct 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notifier.Notification is set to WindowsToaster, which uses SnoreToast

I only set appID for SnoreToast to avoid any effects on other notifiers that might also have an appID parameter.

@tony19
Copy link
Contributor Author

tony19 commented Oct 24, 2020

Once this fix lands, users may want to manually undo the SnoreToast changes from their system, as described below.

Remove SnoreToast shortcut from Start Menu

Option A: File Explorer

  1. Right-click Start Menu > SnoreToast, and choose More > Open File Location, which opens File Explorer.
  2. In File Explorer, delete the root folder of SnoreToast.

Option B: Windows Command Line

  1. Open cmd.exe

  2. Run this rmdir command:

     rmdir /s /q "%APPDATA%\Microsoft\Windows\Start Menu\Programs\SnoreToast"
    

Remove SnoreToast's registry key

Note: SnoreToast sets a registry key in order to register its notification center. The UUID seen in the key is for SnoreToast v0.7.0.

Option A: Registry Editor

  1. Open regedit.exe
  2. In the location textbox at the top, below the menu bar, enter: HKCU\Software\Classes\CLSID\{eb1fdd5b-8f70-4b5a-b230-998a2dc19303} to jump to the key in the registry.
  3. Right-click the {eb1fdd5b-8f70-4b5a-b230-998a2dc19303} folder, and choose Delete.

Option B: Windows Command Line

  1. Open cmd.exe

  2. Run this reg command:

     reg delete /f HKCU\Software\Classes\CLSID\{eb1fdd5b-8f70-4b5a-b230-998a2dc19303}
    

@mellester
Copy link

This is a good thing to have

Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the fix and the detailed guidance!

@sodatea sodatea merged commit cb58c5f into vuejs:dev Nov 14, 2020
sodatea pushed a commit that referenced this pull request Jan 6, 2021
This prevents SnoreToast from installing a Start Menu shortcut
by specifying an appID. The appID is also used to set the
notification's title bar text in Windows 10. That text is now
set to "Vue UI", which replaces the default value of "SnoreToast".

fixes #2720
This was referenced Mar 16, 2021
This was referenced Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SnoreToast is added to the start menu when notifying on Windows
3 participants