Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip checking git gpgSign config #5869

Merged
merged 1 commit into from Sep 10, 2020
Merged

fix: skip checking git gpgSign config #5869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 1 addition & 10 deletions packages/@vue/cli/lib/Creator.js
View file
Open in desktop
Expand Up @@ -259,22 +259,13 @@ module.exports = class Creator extends EventEmitter {

// commit initial state
let gitCommitFailed = false
let gpgSign = false
if (shouldInitGit) {
await run('git add -A')
if (isTestOrDebug) {
await run('git', ['config', 'user.name', 'test'])
await run('git', ['config', 'user.email', 'test@test.com'])
await run('git', ['config', 'commit.gpgSign', 'false'])
}
gpgSign = await (async () => {
const { stdout: gpgSignConfig } = await run('git', [
'config',
'--get',
'commit.gpgSign'
])
return gpgSignConfig === 'true'
})()
const msg = typeof cliOptions.git === 'string' ? cliOptions.git : 'init'
try {
await run('git', ['commit', '-m', msg, '--no-verify'])
Expand All @@ -298,7 +289,7 @@ module.exports = class Creator extends EventEmitter {

if (gitCommitFailed) {
warn(
`Skipped git commit due to missing username and email in git config${gpgSign ? ' or failed to sign commit' : ''}.\n` +
`Skipped git commit due to missing username and email in git config, or failed to sign commit.\n` +
`You will need to perform the initial commit yourself.\n`
)
}
Expand Down