Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli-service): process the webpack failed hook in the serve command #5542

Merged
merged 1 commit into from Jun 2, 2020
Merged

fix(cli-service): process the webpack failed hook in the serve command #5542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/@vue/cli-service/lib/commands/serve.js
View file
Open in desktop
@@ -1,5 +1,6 @@
const {
info,
error,
hasProjectYarn,
hasProjectPnpm,
openBrowser,
Expand Down Expand Up @@ -161,6 +162,12 @@ module.exports = (api, options) => {
// create compiler
const compiler = webpack(webpackConfig)

// handle compiler error
compiler.hooks.failed.tap('vue-cli-service serve', msg => {
error(msg)
process.exit(1)
})

// create server
const server = new WebpackDevServer(compiler, Object.assign({
logLevel: 'silent',
Expand Down