Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): the logs from creator should be displayed in the UI #5493

Merged
merged 2 commits into from May 18, 2020
Merged

fix(ui): the logs from creator should be displayed in the UI #5493

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9586eb8
fix(ui): the logs from creator should be displayed in the UI
sodatea May 16, 2020
448ad64
chore: merge branch 'dev' into fix-ui-log
sodatea May 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 5 additions & 12 deletions packages/@vue/cli/lib/Creator.js
View file
Open in desktop
Expand Up @@ -32,8 +32,6 @@ const {
log,
warn,
error,
logWithSpinner,
stopSpinner,

hasGit,
hasProjectGit,
Expand Down Expand Up @@ -126,7 +124,7 @@ module.exports = class Creator extends EventEmitter {
const pm = new PackageManager({ context, forcePackageManager: packageManager })

await clearConsole()
logWithSpinner(`✨`, `Creating project in ${chalk.yellow(context)}.`)
log(`✨`, `Creating project in ${chalk.yellow(context)}.`)
this.emit('creation', { event: 'creating' })

// get latest CLI plugin version
Expand Down Expand Up @@ -164,13 +162,12 @@ module.exports = class Creator extends EventEmitter {
// so that vue-cli-service can setup git hooks.
const shouldInitGit = this.shouldInitGit(cliOptions)
if (shouldInitGit) {
logWithSpinner(`🗃`, `Initializing git repository...`)
log(`🗃`, `Initializing git repository...`)
this.emit('creation', { event: 'git-init' })
await run('git init')
}

// install plugins
stopSpinner()
log(`⚙\u{fe0f} Installing CLI plugins. This might take a while...`)
log()
this.emit('creation', { event: 'plugins-install' })
Expand Down Expand Up @@ -205,7 +202,7 @@ module.exports = class Creator extends EventEmitter {
}

// run complete cbs if any (injected by generators)
logWithSpinner('⚓', `Running completion hooks...`)
log('⚓', `Running completion hooks...`)
this.emit('creation', { event: 'completion-hooks' })
for (const cb of afterInvokeCbs) {
await cb()
Expand All @@ -216,9 +213,8 @@ module.exports = class Creator extends EventEmitter {

if (!generator.files['README.md']) {
// generate README.md
stopSpinner()
log()
logWithSpinner('📄', 'Generating README.md...')
log('📄', 'Generating README.md...')
await writeFileTree(context, {
'README.md': generateReadme(generator.pkg, packageManager)
})
Expand Down Expand Up @@ -252,7 +248,6 @@ module.exports = class Creator extends EventEmitter {
}

// log instructions
stopSpinner()
log()
log(`🎉 Successfully created project ${chalk.yellow(name)}.`)
if (!cliOptions.skipGetStarted) {
Expand Down Expand Up @@ -330,13 +325,11 @@ module.exports = class Creator extends EventEmitter {
} else if (name.endsWith('.json') || /^\./.test(name) || path.isAbsolute(name)) {
preset = await loadLocalPreset(path.resolve(name))
} else if (name.includes('/')) {
logWithSpinner(`Fetching remote preset ${chalk.cyan(name)}...`)
log(`Fetching remote preset ${chalk.cyan(name)}...`)
this.emit('creation', { event: 'fetch-remote-preset' })
try {
preset = await loadRemotePreset(name, clone)
stopSpinner()
} catch (e) {
stopSpinner()
error(`Failed fetching remote preset ${chalk.cyan(name)}:`)
throw e
}
Expand Down