fix: do not use fork-ts-checker-webpack-plugin for vue-next #5172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cexbrayat
force-pushed
the
fix/ts-vue-next-do-not-use-fork
branch
from
2186023
to
63f16f0
Compare
As the `fork-ts-checker-webpack-plugin` tries to load the compiler, it does not play well at the moment with the vue-next compiler `@vue/compiler-sfc`. This disables the plugin if we are building a vue-next project.
cexbrayat
force-pushed
the
fix/ts-vue-next-do-not-use-fork
branch
from
63f16f0
to
dd259c2
Compare
This was referenced Feb 9, 2020
|
Closing this as #5170 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably a better alternative to #5170
As the
fork-ts-checker-webpack-plugintries to load the compiler, it does not play well at the moment with the vue-next compiler@vue/compiler-sfc. This disables the plugin if we are building a vue-next project.See vuejs/vue-cli-plugin-vue-next#5 for context.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: