Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data is no longer a valid setting for sass-loader #4640

Closed
wants to merge 1 commit into from

Conversation

astr0sl0th
Copy link

When generating a new project with the vue-cli I got had issues configuring my cssLoader options due to the data option being deprecated and prependData being used instead. By using prependData I got my mixins and variables to import correctly.

prependData is now used to import your mixins, variables, etc. Please see https://webpack.js.org/loaders/sass-loader/#prependdata

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

prependData is now used to import your mixins, variables, etc. Please see https://webpack.js.org/loaders/sass-loader/#prependdata
@sodatea
Copy link
Member

sodatea commented Oct 2, 2019

Vue CLI 3.11 is not fully compatible with sass-loader@8. That's why if you choose sass on vue create, it generates a project with sass-loader@7.

So with regard to the documentation, I think it may be a better solution to add a reminder on the sass-loader version than to update the configuration field.

Note: sass-loader@8 is supported is supported in Vue CLI 4.0 rc. But we currently don't have the capacity to backport it to Vue CLI v3 and fully test it. A new release in v3 may come later this month. Before that, please stick with sass-loader@7.

@astr0sl0th
Copy link
Author

@sodatea Would a simple comment suffice?

@sodatea
Copy link
Member

sodatea commented Oct 3, 2019

Yeah, I think so.

@DRoet
Copy link
Contributor

DRoet commented Oct 10, 2019

this can be closed in favor of #4662?

@sodatea
Copy link
Member

sodatea commented Oct 10, 2019

Yeah, fixed in 3.12

@sodatea sodatea closed this Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants