Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edited Dockerfile of Docker(Nginx) deployment doc #4561

Merged
merged 2 commits into from Sep 21, 2019
Merged

Edited Dockerfile of Docker(Nginx) deployment doc #4561

merged 2 commits into from Sep 21, 2019

Commits on Sep 10, 2019

  1. Edited Dockerfile of Docker(Nginx) deployment doc 

    Edited `Dockerfile` section of https://cli.vuejs.org/guide/deployment.html#docker-nginx

As shown in [Vue v2 cookbook](https://vuejs.org/v2/cookbook/dockerize-vuejs-app.html) copying `package*.json` initially and running `npm install` in a separate step allows caching and reduces time elapsed during Docker build. Also the difference between the two docs will be reduced and be less confusing to those who end up with both of them.
    @vahdet
    vahdet committed Sep 10, 2019
    Copy the full SHA
    96739bf View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2019

  1. node version to latest

    @vahdet
    vahdet committed Sep 16, 2019
    Copy the full SHA
    977944c View commit details
    Browse the repository at this point in the history