Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a variant for config get registry #4530

Merged
merged 2 commits into from Oct 11, 2019
Merged

Add a variant for config get registry #4530

merged 2 commits into from Oct 11, 2019

Conversation

arcanis
Copy link
Contributor

@arcanis arcanis commented Aug 31, 2019

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • No

Other information:

We've done a large work to make our configuration more uniform, and some configuration keys have changed. One such key is registry, which is now called npmRegistryServer.

I've also made this code resilient to unforeseen failures.

Ref yarnpkg/berry#368

@arcanis arcanis changed the title Update shouldUseTaobao.js Add a variant for config get registry Aug 31, 2019
@pksunkara pksunkara merged commit 3aa513a into vuejs:dev Oct 11, 2019
@vue-bot
Copy link

vue-bot commented Oct 11, 2019

Hey @arcanis, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants