Fixed progress-path background color for dark mode #3717
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqunjiang
reviewed
Apr 9, 2019
There was a problem hiding this comment.
Thanks for the insight! But I think it looks more consistent when the color is in sync with the animation dot. What do you think?
Current:
Set to $vue-ui-color-dark:
Both set to rgba(black, .1):
Both set to $vue-ui-color-dark:
|
I actually like the 4th one the most 😸 |
Akryum
changed the title
|
The 4th is the best, yeah |
|
I've updated the PR with your sugestions 🙂 |
haoqunjiang
requested changes
Apr 13, 2019
packages/@vue/cli-ui-addon-webpack/src/components/BuildProgress.vue
Outdated
Show resolved
Hide resolved
Co-Authored-By: ajerez <albertoj04@gmail.com>
|
PR updated. Sorry for the delay |
haoqunjiang
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On dark mode the remaining progress bar color was the same color as the background.