Skip to content

Commit

Permalink
feat!: remove @vue/compiler-sfc from peer dependencies (#6808)
Browse files Browse the repository at this point in the history
  • Loading branch information
sodatea committed Nov 5, 2021
1 parent 2163399 commit 60140af
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 18 deletions.
2 changes: 1 addition & 1 deletion packages/@vue/babel-preset-app/package.json
Expand Up @@ -42,7 +42,7 @@
"peerDependencies": {
"@babel/core": "*",
"core-js": "^3",
"vue": "^2 || ^3.0.0-0"
"vue": "^2 || ^3.2.13"
},
"peerDependenciesMeta": {
"core-js": {
Expand Down
2 changes: 1 addition & 1 deletion packages/@vue/cli-plugin-typescript/index.js
Expand Up @@ -85,7 +85,7 @@ module.exports = (api, projectOptions) => {
extensions: {
vue: {
enabled: true,
compiler: isVue3 ? require.resolve('@vue/compiler-sfc') : require.resolve('vue-template-compiler')
compiler: isVue3 ? require.resolve('vue/compiler-sfc') : require.resolve('vue-template-compiler')
}
},
diagnosticOptions: {
Expand Down
7 changes: 2 additions & 5 deletions packages/@vue/cli-plugin-typescript/package.json
Expand Up @@ -37,14 +37,11 @@
},
"peerDependencies": {
"@vue/cli-service": "^3.0.0 || ^4.0.0 || ^5.0.0-0",
"@vue/compiler-sfc": "^3.0.0-beta.14",
"typescript": ">=2",
"vue-template-compiler": "^2.0.0"
"vue-template-compiler": "^2.0.0",
"vue": "^2 || ^3.2.13"
},
"peerDependenciesMeta": {
"@vue/compiler-sfc": {
"optional": true
},
"vue-template-compiler": {
"optional": true
}
Expand Down
1 change: 0 additions & 1 deletion packages/@vue/cli-service/__tests__/generator.spec.js
Expand Up @@ -34,7 +34,6 @@ test('Vue 3', async () => {
})

expect(pkg.dependencies.vue).toMatch('^3')
expect(pkg).toHaveProperty(['devDependencies', '@vue/compiler-sfc'])

expect(files['src/main.js']).toMatch(`import { createApp } from 'vue'`)

Expand Down
5 changes: 1 addition & 4 deletions packages/@vue/cli-service/generator/index.js
Expand Up @@ -7,10 +7,7 @@ module.exports = (api, options) => {
if (options.vueVersion === '3') {
api.extendPackage({
dependencies: {
'vue': '^3.2.6'
},
devDependencies: {
'@vue/compiler-sfc': '^3.2.6'
'vue': '^3.2.13'
}
})
} else {
Expand Down
3 changes: 1 addition & 2 deletions packages/@vue/cli-service/lib/config/base.js
Expand Up @@ -101,8 +101,7 @@ module.exports = (api, options) => {
} else if (vueMajor === 3) {
// for Vue 3 projects
const vueLoaderCacheConfig = api.genCacheConfig('vue-loader', {
'vue-loader': require('vue-loader/package.json').version,
'@vue/compiler-sfc': require('@vue/compiler-sfc/package.json').version
'vue-loader': require('vue-loader/package.json').version
})

webpackConfig.resolve
Expand Down
4 changes: 0 additions & 4 deletions packages/@vue/cli-service/package.json
Expand Up @@ -82,14 +82,10 @@
"whatwg-fetch": "^3.6.2"
},
"peerDependencies": {
"@vue/compiler-sfc": "^3.0.0-beta.14",
"vue-template-compiler": "^2.0.0",
"webpack-sources": "*"
},
"peerDependenciesMeta": {
"@vue/compiler-sfc": {
"optional": true
},
"less-loader": {
"optional": true
},
Expand Down

0 comments on commit 60140af

Please sign in to comment.