fix: allow turning off theme color tags (#5820)

Co-authored-by: Haoqun Jiang <haoqunjiang@gmail.com>
vuejs · Aug 31, 2020 · 34b58c0 · 34b58c0
1 parent d88d927
commit 34b58c0
Showing 1 changed file with 18 additions and 11 deletions.
diff --git a/packages/@vue/cli-plugin-pwa/lib/HtmlPwaPlugin.js b/packages/@vue/cli-plugin-pwa/lib/HtmlPwaPlugin.js
@@ -111,13 +111,18 @@ module.exports = class HtmlPwaPlugin {
               rel: 'manifest',
               href: getTagHref(publicPath, manifestPath, assetsVersionStr)
             }
-          ),
-          makeTag('meta', {
-            name: 'theme-color',
-            content: themeColor
-          })
+          )
         )
 
+        if (themeColor != null) {
+          data.head.push(
+            makeTag('meta', {
+              name: 'theme-color',
+              content: themeColor
+            })
+          )
+        }
+
         // Add to home screen for Safari on iOS
         data.head.push(
           makeTag('meta', {
@@ -154,12 +159,14 @@ module.exports = class HtmlPwaPlugin {
             content: getTagHref(publicPath, iconPaths.msTileImage, assetsVersionStr)
           }))
         }
-        data.head.push(
-          makeTag('meta', {
-            name: 'msapplication-TileColor',
-            content: msTileColor
-          })
-        )
+        if (msTileColor != null) {
+          data.head.push(
+            makeTag('meta', {
+              name: 'msapplication-TileColor',
+              content: msTileColor
+            })
+          )
+        }
 
         cb(null, data)
       })