Skip to content

Commit

Permalink
fix(v3): do not install core plugins that have major version bumps (#…
Browse files Browse the repository at this point in the history
…4712)

* fix(v3): do not install core plugins that have major version bumps

* chore: remove comment [ci skip]
  • Loading branch information
sodatea committed Oct 18, 2019
1 parent 84be64d commit 147f3c1
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions packages/@vue/cli/lib/Creator.js
Expand Up @@ -107,9 +107,8 @@ module.exports = class Creator extends EventEmitter {
logWithSpinner(`✨`, `Creating project in ${chalk.yellow(context)}.`)
this.emit('creation', { event: 'creating' })

// get latest CLI version
const { latest } = await getVersions()
const latestMinor = `${semver.major(latest)}.${semver.minor(latest)}.0`
const { current } = await getVersions()
const currentMinor = `${semver.major(current)}.${semver.minor(current)}.0`
// generate package.json with plugin dependencies
const pkg = {
name,
Expand All @@ -128,7 +127,7 @@ module.exports = class Creator extends EventEmitter {
// Other `@vue/*` packages' version may not be in sync with the cli itself.
pkg.devDependencies[dep] = (
preset.plugins[dep].version ||
((/^@vue/.test(dep)) ? `^${latestMinor}` : `latest`)
((/^@vue/.test(dep)) ? `^${currentMinor}` : `latest`)
)
})
// write package.json
Expand Down

0 comments on commit 147f3c1

Please sign in to comment.