fix(e2e): shouldn't install webdrivers for unchecked browsers on crea…

…tion (#5736)
vuejs · Aug 3, 2020 · 1030f39 · 1030f39
1 parent de3d062
commit 1030f39
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/packages/@vue/cli/lib/promptModules/__tests__/e2e.spec.js b/packages/@vue/cli/lib/promptModules/__tests__/e2e.spec.js
@@ -54,7 +54,9 @@ test('nightwatch', async () => {
 
   const expectedOptions = {
     plugins: {
-      '@vue/cli-plugin-e2e-nightwatch': {}
+      '@vue/cli-plugin-e2e-nightwatch': {
+        webdrivers: ['chrome', 'firefox']
+      }
     }
   }
 
@@ -87,7 +89,9 @@ test('webdriverio', async () => {
 
   const expectedOptions = {
     plugins: {
-      '@vue/cli-plugin-e2e-webdriverio': {}
+      '@vue/cli-plugin-e2e-webdriverio': {
+        webdrivers: ['chrome', 'firefox']
+      }
     }
   }
 

diff --git a/packages/@vue/cli/lib/promptModules/e2e.js b/packages/@vue/cli/lib/promptModules/e2e.js
@@ -58,9 +58,13 @@ module.exports = cli => {
     if (answers.e2e === 'cypress') {
       options.plugins['@vue/cli-plugin-e2e-cypress'] = {}
     } else if (answers.e2e === 'nightwatch') {
-      options.plugins['@vue/cli-plugin-e2e-nightwatch'] = {}
+      options.plugins['@vue/cli-plugin-e2e-nightwatch'] = {
+        webdrivers: answers.webdrivers
+      }
     } else if (answers.e2e === 'webdriverio') {
-      options.plugins['@vue/cli-plugin-e2e-webdriverio'] = {}
+      options.plugins['@vue/cli-plugin-e2e-webdriverio'] = {
+        webdrivers: answers.webdrivers
+      }
     }
   })
 }