New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

footer prev / next navigation landmark has a unique name [#3516] #3801

Merged

brc-dd merged 2 commits into vuejs:main from olets:3516-footer-a11y

Apr 26, 2024

Contributor

olets commented Apr 18, 2024 •

edited

Fixes #3516

accessibility: prev / next navigation landmark does not have a unique name #3516

To test:

On a Vitepress site using the released version, run axe DevTools on any page that has the footer pager nav. Confirm the error described in the linked issue
Repeat on this branch. Confirm that the error is gone.

Questions:

Maybe there's a better name than "Pager"?


          feat(VPDocFooter): pager nav has aria label [vuejs#3516]

db29920

olets mentioned this pull request

footer prev / next navigation landmark has a unique name [upstream 3516] olets/vitepress#1

Merged


          format

5cddee1

brc-dd approved these changes

View reviewed changes

brc-dd merged commit e60c101 into vuejs:main

6 of 7 checks passed

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.