Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): default to vertical align top on badges inside headings #1584

Merged
merged 4 commits into from Nov 30, 2022
Merged

fix(theme): default to vertical align top on badges inside headings #1584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ddd6b14
docs: remove vertical props
shigma Nov 6, 2022
fe2e4a3
feat(theme): badges in headers should be on top
shigma Nov 6, 2022
6529cb1
refa: move styles to sfc
shigma Nov 9, 2022
080b95c
Update VPBadge.vue
brc-dd Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/guide/theme-badge.md
View file
Open in desktop
Expand Up @@ -15,10 +15,10 @@ You may use the `Badge` component which is globally available.

Code above renders like:

### Title <Badge type="info" text="default" vertical="middle" />
### Title <Badge type="tip" text="^1.9.0" vertical="middle" />
### Title <Badge type="warning" text="beta" vertical="middle" />
### Title <Badge type="danger" text="caution" vertical="middle" />
### Title <Badge type="info" text="default" />
### Title <Badge type="tip" text="^1.9.0" />
### Title <Badge type="warning" text="beta" />
### Title <Badge type="danger" text="caution" />

## Custom Children

Expand Down
11 changes: 10 additions & 1 deletion src/client/theme-default/components/VPBadge.vue
View file
Open in desktop
Expand Up @@ -19,11 +19,20 @@ defineProps<{
border-radius: 10px;
padding: 0 8px;
line-height: 18px;
font-size: 13px;
font-size: 12px;
font-weight: 600;
transform: translateY(-2px);
}

h1 .VPBadge,
h2 .VPBadge,
h3 .VPBadge,
h4 .VPBadge,
h5 .VPBadge,
h6 .VPBadge {
vertical-align: top;
}

h2 .VPBadge {
border-radius: 11px;
line-height: 20px;
Expand Down