New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use definition from defineProps
if possible
#3838
base: master
Are you sure you want to change the base?
Conversation
Sorry for the delay, I think this problem is best solved by |
I didn't try this approach, but I think making changes to |
d0abf57
to
aab3a8a
Compare
#3779, #3820 should have been resolved via vuejs/core#10801 + 68edc1d. I reverted the PR's fix but kept the tests, but there are some other tests that are broken due to a regression in Vue 3.5, so they can't be merged for now. |
"pnpm": { | ||
"overrides": { | ||
"@vue/runtime-dom": "alpha", | ||
"@vue/shared": "alpha", | ||
"@vue/compiler-dom": "alpha", | ||
"@vue/compiler-sfc": "alpha", | ||
"vue": "alpha" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't doing overrides at this level also affect/break vue 2 tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not affect Vue 2 tests. Since this PR will only be merged when Vue 3.5 is released, this json section will be removed before merging.
fixes #3779, fixes #3820