chore: consider noPropertyAccessFromIndexSignature when generating …

…virtual code close #3106
vuejs · May 3, 2023 · d740ea0 · d740ea0
1 parent 717cb8c
commit d740ea0
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/packages/vue-language-core/src/generators/template.ts b/packages/vue-language-core/src/generators/template.ts
@@ -62,6 +62,7 @@ type Code = Segment<FileRangeCapabilities>;
 
 export function generate(
 	ts: typeof import('typescript/lib/tsserverlibrary'),
+	compilerOptions: ts.CompilerOptions,
 	vueCompilerOptions: VueCompilerOptions,
 	sourceTemplate: string,
 	sourceLang: string,
@@ -1767,7 +1768,7 @@ export function generate(
 
 	function createPropertyAccessCode(a: Code, astHolder?: any): Code[] {
 		const aStr = typeof a === 'string' ? a : a[0];
-		if (validTsVar.test(aStr)) {
+		if (!compilerOptions.noPropertyAccessFromIndexSignature && validTsVar.test(aStr)) {
 			return ['.', a];
 		}
 		else if (aStr.startsWith('[') && aStr.endsWith(']')) {

diff --git a/packages/vue-language-core/src/plugins/vue-tsx.ts b/packages/vue-language-core/src/plugins/vue-tsx.ts
@@ -138,6 +138,7 @@ const plugin: VueLanguagePlugin = ({ modules, vueCompilerOptions, compilerOption
 
 			return templateGen.generate(
 				ts,
+				compilerOptions,
 				vueCompilerOptions,
 				_sfc.template?.content ?? '',
 				_sfc.template?.lang ?? 'html',

diff --git a/packages/vue-test-workspace/vue-tsc/#3106/main.vue b/packages/vue-test-workspace/vue-tsc/#3106/main.vue
@@ -0,0 +1,14 @@
+<script setup lang="ts">
+let Comp: new () => {
+	$props: {};
+	$slots: {
+		[key: string]: string;
+	};
+};
+</script>
+
+<template>
+	<Comp>
+		<template v-slot:slot-name></template>
+	</Comp>
+</template>