fix: goto definition not working with mapping failed edge cases

close #1048, close #435
vuejs · Mar 20, 2022 · 96a5872 · 96a5872
1 parent 924f1e2
commit 96a5872
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/packages/vue-code-gen/src/generators/script.ts b/packages/vue-code-gen/src/generators/script.ts
@@ -100,6 +100,23 @@ export function generate(
 		);
 	}
 
+	// fix https://github.com/johnsoncodehk/volar/issues/1048, https://github.com/johnsoncodehk/volar/issues/435
+	codeGen.addMapping2({
+		data: {
+			vueTag: 'sfc',
+			capabilities: {},
+		},
+		mode: SourceMaps.Mode.Expand,
+		mappedRange: {
+			start: 0,
+			end: codeGen.getText().length,
+		},
+		sourceRange: {
+			start: 0,
+			end: 0,
+		},
+	});
+
 	return {
 		codeGen,
 		teleports,

diff --git a/packages/vue-typescript/src/use/useSfcScriptGen.ts b/packages/vue-typescript/src/use/useSfcScriptGen.ts
@@ -59,12 +59,8 @@ export function useSfcScriptGen<T extends 'template' | 'script'>(
 	});
 	const file = computed(() => {
 
-		let _fileName: string | undefined;
-
 		if (lsType === 'script') {
 
-			_fileName = fileName + '.' + lang.value
-
 			const file: EmbeddedFile = {
 				lsType,
 				fileName: fileName + '.' + lang.value,