Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add vuepress documentation #534

Merged
merged 108 commits into from Dec 3, 2018
Merged

Docs: add vuepress documentation #534

merged 108 commits into from Dec 3, 2018

Conversation

mysticatea
Copy link
Member

This is working in progress.

I'm trying to make the documentation with VuePress.

You can review it with:

  1. Checkout this branch.
  2. npm install
  3. npm run docs:watch
  4. Open http://localhost:8080/eslint-plugin-vue/

It will be similar to https://mysticatea.github.io/eslint-plugin-es/


Pros:

Cons:

  • It's hard to keep old version's content.

@armano2
Copy link
Collaborator

armano2 commented Nov 26, 2018

@michalsnik your package tree is broken, remove node_modules, package-lock and npm i again

its bug with npm

Sounds like you have encountered this npm's bug eslint/eslint#11018.
Please try to remove package-lock.json and node_modules then re-install all.

@michalsnik
Copy link
Member

Weird @armano2. First thing I did was to remove node_modules and clean cache, but it didn't help. Now I updated this branch on my other computer and it works 🤔

@michalsnik
Copy link
Member

I think that's it! And since it's all about documentation there's no better person to mention here, but @chrisvfritz would you give it a look? :) I think It's the final part before releasing v5

@armano2
Copy link
Collaborator

armano2 commented Nov 26, 2018

@michalsnik looks like fileInfo data is not updated when # title is present

Copy link
Contributor

@chrisvfritz chrisvfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work on this! A few, mostly nitpicky comments:

  • The negative top margin on blockquotes is looking a little strange directly underneath h1s.

  • In the interactive code examples, I'm seeing:

    [ESLint] Parsing error: acorn.Parser.extend is not a function (FATAL)

  • The bottom padding of the interactive code examples seems a little excessive and I think might also be increasing a little with each line in the initial code.

  • This is definitely a nitpick and something we can skip for now, but is there any chance we could get the interactive code examples styled more similarly to the other code examples?

@armano2
Copy link
Collaborator

armano2 commented Nov 30, 2018

@chrisvfritz


if you are going to have issues with arcon.Parse you can preview it here: https://armano2.github.io/eslint-plugin-vue/

@chrisvfritz
Copy link
Contributor

@armano2 Thanks! Apologies for missing that comment in the above thread. 😅 I just checked out the demo you linked to and the interactive editor looks fantastic. 😻

@michalsnik
Copy link
Member

I made the negative margin on purpose @chrisvfritz. Do you think we should remove it?
image

git add -A
git commit -m 'deploy'
git push -f git@github.com:vuejs/eslint-plugin-vue.git master:gh-pages

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about using something like this instead:

https://github.com/eldarlabs/ghpages-deploy-script/blob/master/scripts/deploy-ghpages.sh

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the benefits of using it instead? I copied deploy script from the official Vuepress documentation :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of making one commit and force pushing it over and over again, its adding changes only

Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, now or never. Time to ship it. It already grew soo much.

@michalsnik michalsnik merged commit 025fb16 into master Dec 3, 2018
@michalsnik michalsnik deleted the vuepress branch December 3, 2018 11:55
@michalsnik michalsnik changed the title [WIP] Docs: add vuepress documentation Docs: add vuepress documentation Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants