Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v-bind-style): only change kebabCase to camelCase #2410

Merged
merged 2 commits into from
Feb 27, 2024
Merged

fix(v-bind-style): only change kebabCase to camelCase #2410

merged 2 commits into from
Feb 27, 2024

Conversation

waynzh
Copy link
Contributor

@waynzh waynzh commented Feb 27, 2024

fix #2409

FloEdelmann
FloEdelmann reviewed Feb 27, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I have one suggestion for an additional test case, otherwise this looks good to me already 🙂

tests/lib/rules/v-bind-style.js Show resolved Hide resolved
FloEdelmann
FloEdelmann approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

ota-meshi
ota-meshi approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 7c5e1ee into vuejs:master Feb 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sameNameShorthand from vue/v-bind-style confuses hyphens with underscores
3 participants
@waynzh @FloEdelmann @ota-meshi