fix: support multiple macro calls in vue/define-macros-order #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
requested changes
Jan 31, 2024
| { | ||
| order: ['defineModel', 'defineSlots'] | ||
| } | ||
| ] |
There was a problem hiding this comment.
Thank you for this PR!
Could you also add invalid test cases with multiple defineModels?
There was a problem hiding this comment.
Added a couple I could think of. Also one that tests that order of occurrence is maintained and not re-ordered like I suggested in the initial issue
Can you think of any other interesting cases to check?
FloEdelmann
reviewed
Jan 31, 2024
lib/rules/define-macros-order.js
Outdated
| .map((name) => ({ name, node: macrosNodes.get(name) })) | ||
| .flatMap((name) => { | ||
| const nodes = macrosNodes.get(name) ?? [] | ||
| return nodes?.map((node) => ({ name, node })) |
There was a problem hiding this comment.
This can't be undefined, since you are using ?? above.
Suggested change
| return nodes?.map((node) => ({ name, node })) | |
| return nodes.map((node) => ({ name, node })) |
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a pro when it comes to AST stuff, but I think this should do it.
Should fix #2371