Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eslint-plugin-unicorn to v47 #2146

Merged
merged 10 commits into from
May 8, 2023
Merged

Update eslint-plugin-unicorn to v47 #2146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
03b4543
chore: update eslint-plugin-unicorn
TatsuyaYamamoto May 6, 2023
27e8ada
chore: run 'npm run lint:fix'
TatsuyaYamamoto May 6, 2023
e4f6218
chore: set top-level await
TatsuyaYamamoto May 6, 2023
92305cc
Revert "chore: set top-level await"
TatsuyaYamamoto May 7, 2023
41b22e1
chore: turn off 'unicorn/prefer-top-level-await'
TatsuyaYamamoto May 7, 2023
adf77e9
Revert "chore: run 'npm run lint:fix'"
TatsuyaYamamoto May 7, 2023
f29cc81
chore: turn off lint rules
TatsuyaYamamoto May 7, 2023
c9ab283
Merge branch 'master' into update-eslint-plugin-unicorn
ota-meshi May 7, 2023
49e398f
Update .eslintrc.js
ota-meshi May 7, 2023
6f4dca6
chore: edit comments
TatsuyaYamamoto May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 8 additions & 5 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,16 +128,19 @@ module.exports = {
'unicorn/filename-case': 'off',
'unicorn/no-null': 'off',
'unicorn/no-array-callback-reference': 'off', // doesn't work well with TypeScript's custom type guards
'unicorn/no-negated-condition': 'off', // remove when there are few pull requests (ref: #2146)
'unicorn/no-useless-undefined': 'off',
'unicorn/prefer-optional-catch-binding': 'off', // not supported by current ESLint parser version
'unicorn/prefer-module': 'off',
'unicorn/prevent-abbreviations': 'off',
'unicorn/prefer-at': 'off', // turn off to prevent make breaking changes (ref: #2146)
'unicorn/prefer-node-protocol': 'off', // turn off to prevent make breaking changes (ref: #2146)
'unicorn/prefer-string-replace-all': 'off', // turn off to prevent make breaking changes (ref: #2146)
'unicorn/prefer-ternary': 'off', // remove when there are few pull requests (ref: #2146)
'unicorn/prefer-top-level-await': 'off', // turn off to prevent make breaking changes (ref: #2146)
'unicorn/switch-case-braces': 'off', // remove when there are few pull requests (ref: #2146)

'require-eslint-community': ['error'],

// FIXME: The version we are currently using is not compatible.
// May be removed in #2146. https://github.com/vuejs/eslint-plugin-vue/pull/2146
'unicorn/expiring-todo-comments': 'off'
'require-eslint-community': ['error']
},
overrides: [
{
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"eslint-plugin-jsonc": "^2.2.1",
"eslint-plugin-node-dependencies": ">=0.5.0 <1.0.0",
"eslint-plugin-prettier": "^4.0.0",
"eslint-plugin-unicorn": "^42.0.0",
"eslint-plugin-unicorn": "^47.0.0",
"eslint-plugin-vue": "file:.",
"espree": "^9.3.2",
"events": "^3.3.0",
Expand Down