Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: better example to clarify rule #1984

Merged
merged 1 commit into from Sep 20, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 8 additions & 4 deletions docs/rules/define-props-declaration.md
Expand Up @@ -21,12 +21,14 @@ This rule only works in setup script and `lang="ts"`.
<script setup lang="ts">
/* ✓ GOOD */
const props = defineProps<{
kind: string
kind: string,
options: { title: string }
}>()

/* ✗ BAD */
const props = defineProps({
kind: { type: String }
kind: { type: String },
options: { type: Object as PropType<{ title: string }> }
})
</script>
```
Expand All @@ -50,12 +52,14 @@ const props = defineProps({
<script setup lang="ts">
/* ✓ GOOD */
const props = defineProps({
kind: { type: String }
kind: { type: String },
options: { type: Object as PropType<{ title: string }> }
})

/* ✗ BAD */
const props = defineProps<{
kind: string
kind: string,
options: { title: string }
}>()
</script>
```
Expand Down