Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(order-in-components): allow autofix with TypeScript PropType #1955

Merged
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/rules/order-in-components.js
Expand Up @@ -171,7 +171,9 @@ function isNotSideEffectsNode(node, visitorKeys) {
node.type === 'Literal' ||
// es2015
node.type === 'ArrowFunctionExpression' ||
node.type === 'TemplateElement'
node.type === 'TemplateElement' ||
// typescript
node.type === 'TSAsExpression'
) {
skipNode = node
} else if (
Expand Down
35 changes: 35 additions & 0 deletions tests/lib/rules/order-in-components.js
Expand Up @@ -908,6 +908,41 @@ ruleTester.run('order-in-components', rule, {
line: 15
}
]
},
{
filename: 'example.vue',
code: `
<script lang="ts">
export default {
setup () {},
props: {
foo: { type: Array as PropType<number[]> },
},
};
</script>
`,
parser: require.resolve('vue-eslint-parser'),
parserOptions: {
...parserOptions,
parser: { ts: require.resolve('@typescript-eslint/parser') }
},
output: `
<script lang="ts">
export default {
props: {
foo: { type: Array as PropType<number[]> },
},
setup () {},
};
</script>
`,
errors: [
{
message:
'The "props" property should be above the "setup" property on line 4.',
line: 5
}
]
}
]
})