Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add no-required-prop-with-default rule #1943

Merged
merged 5 commits into from Sep 20, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/rules/README.md
Expand Up @@ -228,6 +228,7 @@ For example:
| [vue/no-multiple-objects-in-class](./no-multiple-objects-in-class.md) | disallow to pass multiple objects into array to class | | :hammer: |
| [vue/no-potential-component-option-typo](./no-potential-component-option-typo.md) | disallow a potential typo in your component property | :bulb: | :hammer: |
| [vue/no-ref-object-destructure](./no-ref-object-destructure.md) | disallow destructuring of ref objects that can lead to loss of reactivity | | :warning: |
| [vue/no-required-prop-with-default](./no-required-prop-with-default.md) | enforce props with default values ​​to be optional | :wrench: | :warning: |
| [vue/no-restricted-block](./no-restricted-block.md) | disallow specific block | | :hammer: |
| [vue/no-restricted-call-after-await](./no-restricted-call-after-await.md) | disallow asynchronously called restricted methods | | :hammer: |
| [vue/no-restricted-class](./no-restricted-class.md) | disallow specific classes in Vue components | | :warning: |
Expand Down
95 changes: 95 additions & 0 deletions docs/rules/no-required-prop-with-default.md
@@ -0,0 +1,95 @@
---
pageClass: rule-details
sidebarDepth: 0
title: vue/no-required-prop-with-default
description: enforce props with default values ​​to be optional
---
# vue/no-required-prop-with-default

> enforce props with default values ​​to be optional

- :exclamation: <badge text="This rule has not been released yet." vertical="middle" type="error"> ***This rule has not been released yet.*** </badge>
- :wrench: The `--fix` option on the [command line](https://eslint.org/docs/user-guide/command-line-interface#fixing-problems) can automatically fix some of the problems reported by this rule.

## :book: Rule Details

If a prop is declared with a default value, whether it is required or not, we can always skip it in actual use. In that situation, the default value would be applied.
So, a required prop with a default value is essentially the same as an optional prop.
This rule enforces all props with default values to be optional.

<eslint-code-block fix :rules="{'vue/no-required-prop-with-default': ['error', { autoFix: true }]}">

```vue
<script setup lang="ts">
/* ✓ GOOD */
const props = withDefaults(
defineProps<{
name?: string | number
age?: number
}>(),
{
name: "Foo",
}
);

/* ✗ BAD */
const props = withDefaults(
defineProps<{
name: string | number
age?: number
}>(),
{
name: "Foo",
}
);
</script>
```

</eslint-code-block>

<eslint-code-block fix :rules="{'vue/no-required-prop-with-default': ['error', { autoFix: true }]}">

```vue
<script setup lang="ts">
FloEdelmann marked this conversation as resolved.
Show resolved Hide resolved
export default {
/* ✓ GOOD */
props: {
name: {
required: true,
default: 'Hello'
}
}

/* ✗ BAD */
props: {
name: {
required: true,
default: 'Hello'
}
}
}
</script>
```

</eslint-code-block>

## :wrench: Options

```json
{
"vue/no-required-prop-with-default": ["error", {
"autofix": false,
}]
}
```

- `"autofix"` ... If `true`, enable autofix.
FloEdelmann marked this conversation as resolved.
Show resolved Hide resolved

## :couple: Related Rules

- [vue/require-default-prop](./require-default-prop.md)

## :mag: Implementation

- [Rule source](https://github.com/vuejs/eslint-plugin-vue/blob/master/lib/rules/no-required-prop-with-default.js)
- [Test source](https://github.com/vuejs/eslint-plugin-vue/blob/master/tests/lib/rules/no-required-prop-with-default.js)
1 change: 1 addition & 0 deletions lib/index.js
Expand Up @@ -105,6 +105,7 @@ module.exports = {
'no-potential-component-option-typo': require('./rules/no-potential-component-option-typo'),
'no-ref-as-operand': require('./rules/no-ref-as-operand'),
'no-ref-object-destructure': require('./rules/no-ref-object-destructure'),
'no-required-prop-with-default': require('./rules/no-required-prop-with-default'),
'no-reserved-component-names': require('./rules/no-reserved-component-names'),
'no-reserved-keys': require('./rules/no-reserved-keys'),
'no-reserved-props': require('./rules/no-reserved-props'),
Expand Down
154 changes: 154 additions & 0 deletions lib/rules/no-required-prop-with-default.js
@@ -0,0 +1,154 @@
/**
* @author @neferqiqi
* See LICENSE file in root directory for full license.
*/
'use strict'
// ------------------------------------------------------------------------------
// Requirements
// ------------------------------------------------------------------------------

const utils = require('../utils')
/**
* @typedef {import('../utils').ComponentTypeProp} ComponentTypeProp
*/

// ------------------------------------------------------------------------------
// Helpers
// ------------------------------------------------------------------------------

// ...

// ------------------------------------------------------------------------------
FloEdelmann marked this conversation as resolved.
Show resolved Hide resolved
// Rule Definition
// ------------------------------------------------------------------------------

module.exports = {
meta: {
type: 'problem',
docs: {
description: 'enforce props with default values ​​to be optional',
categories: undefined,
url: 'https://eslint.vuejs.org/rules/no-required-prop-with-default.html'
},
fixable: 'code',
schema: [
{
type: 'object',
properties: {
autofix: {
type: 'boolean'
}
},
additionalProperties: false
}
],
messages: {
// ...
}
},
/** @param {RuleContext} context */
create(context) {
/**
* @param {ComponentTypeProp} prop
* @param {Token[]} tokens
* */
const findKeyToken = (prop, tokens) =>
tokens.find((token) => {
const isKeyIdentifierEqual =
prop.key.type === 'Identifier' && token.value === prop.key.name
const isKeyLiteralEqual =
prop.key.type === 'Literal' && token.value === prop.key.raw
return isKeyIdentifierEqual || isKeyLiteralEqual
})

let canAutoFix = false
const option = context.options[0]
if (option) {
canAutoFix = option.autofix
}

return utils.compositingVisitors(
utils.defineVueVisitor(context, {
onVueObjectEnter(node) {
utils.getComponentPropsFromOptions(node).map((prop) => {
if (
prop.type === 'object' &&
prop.propName &&
prop.value.type === 'ObjectExpression' &&
utils.findProperty(prop.value, 'default')
) {
const requiredProperty = utils.findProperty(
prop.value,
'required'
)
if (!requiredProperty) return
const requiredNode = requiredProperty.value
if (
requiredNode &&
requiredNode.type === 'Literal' &&
!!requiredNode.value
) {
context.report({
node: prop.node,
loc: prop.node.loc,
data: {
key: prop.propName
},
message: `Prop "{{ key }}" should be optional.`,
fix: canAutoFix
ota-meshi marked this conversation as resolved.
Show resolved Hide resolved
? (fixer) => fixer.replaceText(requiredNode, 'false')
: null
})
}
}
})
}
}),
utils.defineScriptSetupVisitor(context, {
onDefinePropsEnter(node, props) {
if (!utils.hasWithDefaults(node)) {
return
}
const withDefaultsProps = Object.keys(
utils.getWithDefaultsPropExpressions(node)
)
const requiredProps = props.flatMap((item) =>
item.type === 'type' && item.required ? [item] : []
)

for (const prop of requiredProps) {
if (withDefaultsProps.includes(prop.propName)) {
const firstToken = context
.getSourceCode()
.getFirstToken(prop.node)
// skip setter & getter case
if (firstToken.value === 'get' || firstToken.value === 'set') {
ota-meshi marked this conversation as resolved.
Show resolved Hide resolved
return
}
// skip computed
if (prop.node.computed) {
return
}
const keyToken = findKeyToken(
prop,
context.getSourceCode().getTokens(prop.node)
)
if (!keyToken) return
context.report({
node: prop.node,
loc: prop.node.loc,
data: {
key: prop.propName
},
message: `Prop "{{ key }}" should be optional.`,
fix: canAutoFix
? (fixer) => fixer.insertTextAfter(keyToken, '?')
ota-meshi marked this conversation as resolved.
Show resolved Hide resolved
: null
})
}
}
}
})
)
}
}