Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vue/no-restricted-class rule #1639

Merged
merged 7 commits into from Sep 29, 2021
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
81 changes: 81 additions & 0 deletions docs/rules/no-restricted-class.md
@@ -0,0 +1,81 @@
---
pageClass: rule-details
sidebarDepth: 0
title: vue/no-restricted-class
description: disallow specific classes
---
# vue/no-restricted-classes

> disallow specific classes

## :book: Rule Details

This rule lets you specify a list of classes that you don't want to allow in your templates.

## :wrench: Options

The simplest way to specify a list of forbidden classes is to pass it directly
in the rule configuration.

```json
{
"vue/no-restricted-props": ["error", "forbidden", "forbidden-two", "forbidden-three"]
}
```

<eslint-code-block :rules="{'vue/no-restricted-class': ['error', 'forbidden']}">

```vue
<template>
<!-- ✗ BAD -->
<div class="forbidden" />
<div :class="{forbidden: someBoolean}" />
<div :class="`forbidden ${someString}`" />
<div :class="'forbidden'" />
<div :class="'forbidden ' + someString" />
<div :class="[someString, 'forbidden']" />
<!-- ✗ GOOD -->
<div class="allowed-class" />
</template>

<script>
export default {
props: {
someBoolean: Boolean,
someString: String,
}
}
</script>
```

</eslint-code-block>

::: warning Note
This rule will only detect classes that are used as strings in your templates. Passing classes via
variables, like below, will not be detected by this rule.

```vue
<template>
<div :class="classes" />
</template>

<script>
export default {
data() {
return {
classes: "forbidden"
}
}
}
</script>
```
:::

## :rocket: Version

This rule was introduced in eslint-plugin-vue v7.19.0.

## :mag: Implementation

- [Rule source](https://github.com/vuejs/eslint-plugin-vue/blob/master/lib/rules/no-restricted-class.js)
- [Test source](https://github.com/vuejs/eslint-plugin-vue/blob/master/tests/lib/rules/no-restricted-class.js)
154 changes: 154 additions & 0 deletions lib/rules/no-restricted-class.js
@@ -0,0 +1,154 @@
/**
* @fileoverview Forbid certain classes from being used
* @author Tao Bojlen
*/
'use strict'

// ------------------------------------------------------------------------------
// Requirements
// ------------------------------------------------------------------------------
const utils = require('../utils')

// ------------------------------------------------------------------------------
// Helpers
// ------------------------------------------------------------------------------
/**
* Report a forbidden class
* @param {string} className
* @param {*} node
* @param {RuleContext} context
* @param {Set<string>} forbiddenClasses
*/
const reportForbiddenClass = (className, node, context, forbiddenClasses) => {
if (forbiddenClasses.has(className)) {
const loc = node.value ? node.value.loc : node.loc
context.report({
node,
loc,
messageId: 'forbiddenClass',
data: {
class: className
}
})
}
}

/**
* @param {Expression} node
* @param {boolean} [textOnly]
* @returns {IterableIterator<{ className:string, reportNode: ESNode }>}
*/
function* extractClassNames(node, textOnly) {
if (node.type === 'Literal') {
yield* `${node.value}`
.split(/\s+/)
.map((className) => ({ className, reportNode: node }))
return
}
if (node.type === 'TemplateLiteral') {
for (const templateElement of node.quasis) {
yield* templateElement.value.cooked
.split(/\s+/)
.map((className) => ({ className, reportNode: templateElement }))
}
for (const expr of node.expressions) {
yield* extractClassNames(expr, true)
}
return
}
if (node.type === 'BinaryExpression') {
if (node.operator !== '+') {
return
}
yield* extractClassNames(node.left, true)
yield* extractClassNames(node.right, true)
return
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a mistake in the if statement. We need to add the following:

Suggested change
}
}
if (textOnly) {
return
}

<template><div :class="''+{forbidden:true}">Content</div></template> is actually drawn as <div class="[object Object]">Content</div>.

https://sfc.vuejs.org/#eyJBcHAudnVlIjoiPHRlbXBsYXRlPjxkaXYgOmNsYXNzPVwiJycre2ZvcmJpZGRlbjp0cnVlfVwiPkNvbnRlbnQ8L2Rpdj48L3RlbXBsYXRlPiIsImltcG9ydC1tYXAuanNvbiI6IntcbiAgXCJpbXBvcnRzXCI6IHtcbiAgICBcInZ1ZVwiOiBcImh0dHBzOi8vc2ZjLnZ1ZWpzLm9yZy92dWUucnVudGltZS5lc20tYnJvd3Nlci5qc1wiXG4gIH1cbn0ifQ==

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you; fixed -- and added a test case.

if (node.type === 'ObjectExpression') {
for (const prop of node.properties) {
if (prop.type !== 'Property') {
continue
}
const classNames = utils.getStaticPropertyName(prop)
if (!classNames) {
continue
}
yield* classNames
.split(/\s+/)
.map((className) => ({ className, reportNode: prop.key }))
}
return
}
if (node.type === 'ArrayExpression') {
for (const element of node.elements) {
if (element == null) {
continue
}
if (element.type === 'SpreadElement') {
continue
}
yield* extractClassNames(element)
}
return
}
if (!textOnly) {
return
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!textOnly) {
return
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amended.

}

// ------------------------------------------------------------------------------
// Rule Definition
// ------------------------------------------------------------------------------
module.exports = {
meta: {
type: 'problem',
docs: {
description: 'disallow specific classes in Vue components',
url: 'https://eslint.vuejs.org/rules/no-restricted-class.html',
categories: undefined
},
fixable: null,
messages: {
forbiddenClass: "'{{class}}' class is not allowed."
},
schema: {
type: 'array',
items: {
type: 'string'
}
}
},

/** @param {RuleContext} context */
create(context) {
const forbiddenClasses = new Set(context.options || [])

return utils.defineTemplateBodyVisitor(context, {
/**
* @param {VAttribute & { value: VLiteral } } node
*/
'VAttribute[directive=false][key.name="class"]'(node) {
node.value.value
.split(/\s+/)
.forEach((className) =>
reportForbiddenClass(className, node, context, forbiddenClasses)
)
},

/** @param {VExpressionContainer} node */
"VAttribute[directive=true][key.name.name='bind'][key.argument.name='class'] > VExpressionContainer.value"(
node
) {
if (!node.expression) {
return
}

for (const { className, reportNode } of extractClassNames(
/** @type {Expression} */ (node.expression)
)) {
reportForbiddenClass(className, reportNode, context, forbiddenClasses)
}
}
})
ota-meshi marked this conversation as resolved.
Show resolved Hide resolved
}
}
114 changes: 114 additions & 0 deletions tests/lib/rules/no-restricted-class.js
@@ -0,0 +1,114 @@
/**
* @author Tao Bojlen
*/

'use strict'

const rule = require('../../../lib/rules/no-restricted-class')
const RuleTester = require('eslint').RuleTester

const ruleTester = new RuleTester({
parser: require.resolve('vue-eslint-parser'),
parserOptions: { ecmaVersion: 2020, sourceType: 'module' }
})

ruleTester.run('no-restricted-class', rule, {
valid: [
{ code: `<template><div class="allowed">Content</div></template>` },
{
code: `<template><div class="allowed"">Content</div></template>`,
options: ['forbidden']
},
{
code: `<template><div :class="'allowed' + forbidden">Content</div></template>`,
options: ['forbidden']
},
{
code: `<template><div @class="forbidden">Content</div></template>`,
options: ['forbidden']
}
],

invalid: [
{
code: `<template><div class="forbidden allowed" /></template>`,
errors: [
{
message: "'forbidden' class is not allowed.",
type: 'VAttribute'
}
],
options: ['forbidden']
},
{
code: `<template><div :class="'forbidden' + ' ' + 'allowed' + someVar" /></template>`,
errors: [
{
message: "'forbidden' class is not allowed.",
type: 'Literal'
}
],
options: ['forbidden']
},
{
code: `<template><div :class="{'forbidden': someBool, someVar: true}" /></template>`,
errors: [
{
message: "'forbidden' class is not allowed.",
type: 'Literal'
}
],
options: ['forbidden']
},
{
code: `<template><div :class="{forbidden: someBool}" /></template>`,
errors: [
{
message: "'forbidden' class is not allowed.",
type: 'Identifier'
}
],
options: ['forbidden']
},
{
code: '<template><div :class="`forbidden ${someVar}`" /></template>',
errors: [
{
message: "'forbidden' class is not allowed.",
type: 'TemplateElement'
}
],
options: ['forbidden']
},
{
code: `<template><div :class="'forbidden'" /></template>`,
errors: [
{
message: "'forbidden' class is not allowed.",
type: 'Literal'
}
],
options: ['forbidden']
},
{
code: `<template><div :class="['forbidden', 'allowed']" /></template>`,
errors: [
{
message: "'forbidden' class is not allowed.",
type: 'Literal'
}
],
options: ['forbidden']
},
{
code: `<template><div :class="['allowed forbidden', someString]" /></template>`,
errors: [
{
message: "'forbidden' class is not allowed.",
type: 'Literal'
}
],
options: ['forbidden']
}
]
})