Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false negative with require-valid-default-prop on props with type assertion #1469

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/rules/require-valid-default-prop.js
Expand Up @@ -49,10 +49,11 @@ function getPropertyNode(obj, name) {
}

/**
* @param {Expression} node
* @param {Expression} targetNode
* @returns {string[]}
*/
function getTypes(node) {
function getTypes(targetNode) {
const node = utils.skipTSAsExpression(targetNode)
if (node.type === 'Identifier') {
return [node.name]
} else if (node.type === 'ArrayExpression') {
Expand Down
90 changes: 90 additions & 0 deletions tests/lib/rules/require-valid-default-prop.js
Expand Up @@ -207,6 +207,51 @@ ruleTester.run('require-valid-default-prop', rule, {
}
}`,
parserOptions
},
{
filename: 'test.vue',
code: `export default Vue.extend({
props: {
foo: {
type: Array as PropType<string[]>,
default: () => []
}
}
});
`,
parserOptions: { ecmaVersion: 6, sourceType: 'module' },
parser: require.resolve('@typescript-eslint/parser'),
errors: errorMessage('function')
},
{
filename: 'test.vue',
code: `export default Vue.extend({
props: {
foo: {
type: Object as PropType<{ [key: number]: number }>,
default: () => {}
}
}
});
`,
parserOptions: { ecmaVersion: 6, sourceType: 'module' },
parser: require.resolve('@typescript-eslint/parser'),
errors: errorMessage('function')
},
{
filename: 'test.vue',
code: `export default Vue.extend({
props: {
foo: {
type: Function as PropType<() => number>,
default: () => 10
}
}
});
`,
parserOptions: { ecmaVersion: 6, sourceType: 'module' },
parser: require.resolve('@typescript-eslint/parser'),
errors: errorMessage('function')
}
],

Expand Down Expand Up @@ -781,6 +826,51 @@ ruleTester.run('require-valid-default-prop', rule, {
}`,
parserOptions,
errors: errorMessage('string')
},
{
filename: 'test.vue',
code: `export default Vue.extend({
props: {
foo: {
type: Array as PropType<string[]>,
default: []
}
}
});
`,
parserOptions: { ecmaVersion: 6, sourceType: 'module' },
parser: require.resolve('@typescript-eslint/parser'),
errors: errorMessage('function')
},
{
filename: 'test.vue',
code: `export default Vue.extend({
props: {
foo: {
type: Object as PropType<{ [key: number]: number }>,
default: {}
}
}
});
`,
parserOptions: { ecmaVersion: 6, sourceType: 'module' },
parser: require.resolve('@typescript-eslint/parser'),
errors: errorMessage('function')
},
{
filename: 'test.vue',
code: `export default Vue.extend({
props: {
foo: {
type: Function as PropType<() => number>,
default: 10
}
}
});
`,
parserOptions: { ecmaVersion: 6, sourceType: 'module' },
parser: require.resolve('@typescript-eslint/parser'),
errors: errorMessage('function')
}
]
})