New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin-vue): [valid-v-bind-sync] Added Case: when valid is then valid .sync #1335
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
92f550a
fix(eslint-plugin-vue): [valid-v-bind-sync] If Valid Is then .sync is…
aggmoulik e618757
Formatted Document
aggmoulik 9eb250c
fix: [v-bind-sync] added check for :is bind attribute
aggmoulik 25e5139
fix: [valid-v-bind-sync] add unit tests for `v-bind:is`
aggmoulik fab2761
Update tests/lib/rules/valid-v-bind-sync.js
ota-meshi b5a7016
Update package.json
ota-meshi File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,8 @@ | |
"version": "npm run lint -- --fix && git add .", | ||
"update": "node ./tools/update.js", | ||
"docs:watch": "vuepress dev docs", | ||
"docs:build": "vuepress build docs" | ||
"docs:build": "vuepress build docs", | ||
"tests": "mocha" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do not change the script. You may be able to use
ota-meshi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}, | ||
"files": [ | ||
"lib" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to check if it is v-bind. Also, the argument can be null.
https://github.com/vuejs/vue-eslint-parser/blob/master/docs/ast.md#vdirectivekey
In addition, could you add a test to make sure it is not judged as
is
?