New Add vue/no-computed-in-data Rule
#1075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
almost finish #958 |
IWANABETHATGUY
commented
Mar 15, 2020
|
@ota-meshi could please help for review? |
IWANABETHATGUY
changed the title
IWANABETHATGUY
changed the title
vue/no-computed-in-data Rule
ota-meshi
requested changes
Mar 31, 2020
IWANABETHATGUY
commented
Apr 4, 2020
| </script> | ||
| ` | ||
| }, | ||
| // should not warn when objectExpression is not a vue component |
There was a problem hiding this comment.
ota-meshi
requested changes
Apr 15, 2020
| } | ||
| const computedPropertyNameList = utils.getComputedProperties(obj).map(item => `this.${item.key}`) | ||
| Object.keys(memberExpressionMap).forEach(fullName => { | ||
| const index = computedPropertyNameList.findIndex(name => fullName.startsWith(name)) |
There was a problem hiding this comment.
There is no need to use startsWith.
Suggested change
| const index = computedPropertyNameList.findIndex(name => fullName.startsWith(name)) | |
| const index = computedPropertyNameList.findIndex(name => fullName === name) |
| } | ||
| }, | ||
| MemberExpression (node) { | ||
| if (dataAstNode && dataPropertyScope === topOfStack(scopeStack)) { |
There was a problem hiding this comment.
Vue components may not be at the top level.
export default {
components: {
// @vue/component
MyComponent: {
data() {
return {
bar: this.baz
}
},
computed: {
baz() {}
}
}
},
}| const fullName = utils.parseMemberExpression(node).slice(0, 2).join('.') | ||
| if (memberExpressionMap[fullName]) { | ||
| // check if parent node in this array, if true ignore this node, such as `{a: this.a.c.d}`, this traverse function visit order is `this.a.c.d` -> `a.c.d` -> `c.d` | ||
| const hasParentNodeInArray = memberExpressionMap[fullName].some(nodeInMap => node.parent === nodeInMap) |
There was a problem hiding this comment.
I've found an issue with duplicate reports when the chain is deep. Perhaps checking the parent is a problem.
<script>
export default {
data() {
return {
a: this.test.foo.bar.baz,
}
},
computed: {
test() {
return {}
},
}
}
</script>
g-plane
reviewed
Mar 3, 2021
| // ------------------------------------------------------------------------------ | ||
| const utils = require('../utils') | ||
| function topOfStack (stack) { | ||
| console.assert(Array.isArray(stack)) |
There was a problem hiding this comment.
Why is there a console.assert call here?
|
This PR seems to be out of date, so I will close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #958