pref: improve traverse (#912)

* pref: improve traverse * ci: trigger build * Remove throw trick
vuejs · Aug 16, 2019 · d822a03 · d822a03
1 parent cb2e367
commit d822a03
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/lib/rules/order-in-components.js b/lib/rules/order-in-components.js
@@ -97,27 +97,22 @@ function isNotSideEffectsNode (node, visitorKeys) {
   traverseNodes(node, {
     visitorKeys,
     enterNode (node, parent) {
-      if (!result || noSideEffectsNodes.has(node)) {
+      if (!result) {
         return
       }
 
       if (
+        // parent has no side effects
+        noSideEffectsNodes.has(parent) ||
+        // no side effects node
         node.type === 'FunctionExpression' ||
         node.type === 'Identifier' ||
         node.type === 'Literal' ||
         // es2015
         node.type === 'ArrowFunctionExpression' ||
         node.type === 'TemplateElement'
       ) {
-        // no side effects node
         noSideEffectsNodes.add(node)
-        traverseNodes(node, {
-          visitorKeys,
-          enterNode (node) {
-            noSideEffectsNodes.add(node)
-          },
-          leaveNode () {}
-        })
       } else if (
         node.type !== 'Property' &&
         node.type !== 'ObjectExpression' &&
@@ -137,6 +132,7 @@ function isNotSideEffectsNode (node, visitorKeys) {
     },
     leaveNode () {}
   })
+
   return result
 }